From: Lubos Lunak Date: Thu, 1 May 2014 13:50:44 +0000 (+0000) Subject: do not use "1" for line marker for the main file X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9de1702d31ae13c59ba9427343ec867fe7da3427;p=clang do not use "1" for line marker for the main file "1" means entering a new file (from a different one), but the main file is not included from anything (and this would e.g. confuse -Wunused-macros to not report unused macros in the main file, see pr15610, or also see pr18948). The line marker is still useful e.g. if the resulting file is renamed or used via a pipe. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@207764 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Rewrite/Frontend/InclusionRewriter.cpp b/lib/Rewrite/Frontend/InclusionRewriter.cpp index 4a7d69c26a..ad8328e7ca 100644 --- a/lib/Rewrite/Frontend/InclusionRewriter.cpp +++ b/lib/Rewrite/Frontend/InclusionRewriter.cpp @@ -352,8 +352,11 @@ bool InclusionRewriter::Process(FileID FileId, StringRef EOL = DetectEOL(FromFile); - // Per the GNU docs: "1" indicates the start of a new file. - WriteLineInfo(FileName, 1, FileType, EOL, " 1"); + // Per the GNU docs: "1" indicates entering a new file. + if (FileId == SM.getMainFileID()) + WriteLineInfo(FileName, 1, FileType, EOL, ""); + else + WriteLineInfo(FileName, 1, FileType, EOL, " 1"); if (SM.getFileIDSize(FileId) == 0) return false; diff --git a/test/Frontend/rewrite-includes.c b/test/Frontend/rewrite-includes.c index 2158dd0e8e..619d34a22d 100644 --- a/test/Frontend/rewrite-includes.c +++ b/test/Frontend/rewrite-includes.c @@ -21,6 +21,7 @@ A(1,2) #include "rewrite-includes7.h" #include "rewrite-includes8.h" // ENDCOMPARE +// CHECK: {{^}}# 1 "{{.*}}rewrite-includes.c"{{$}} // CHECK: {{^}}// STARTCOMPARE{{$}} // CHECK-NEXT: {{^}}#define A(a,b) a ## b{{$}} // CHECK-NEXT: {{^}}A(1,2){{$}}