From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 4 Jun 2013 22:13:51 +0000 (+0200)
Subject: Issue #9566: Fix a compiler warning on Windows 64-bit in namespace_init()
X-Git-Tag: v3.4.0a1~574
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9d77664e012a04da43177b218b7fb521e7aeb438;p=python

Issue #9566: Fix a compiler warning on Windows 64-bit in namespace_init()

The result type is int, return -1 to avoid a compiler warning (cast Py_ssize_t
to int).  PyObject_Size() can only fail with -1, and anyway a constructor
should return -1 on error, not an arbitrary negative number.
---

diff --git a/Objects/namespaceobject.c b/Objects/namespaceobject.c
index 7e9107a744..8c51b07fc1 100644
--- a/Objects/namespaceobject.c
+++ b/Objects/namespaceobject.c
@@ -44,7 +44,7 @@ namespace_init(_PyNamespaceObject *ns, PyObject *args, PyObject *kwds)
     if (args != NULL) {
         Py_ssize_t argcount = PyObject_Size(args);
         if (argcount < 0)
-            return argcount;
+            return -1;
         else if (argcount > 0) {
             PyErr_Format(PyExc_TypeError, "no positional arguments expected");
             return -1;