From: Rich Felker <dalias@aerifal.cx>
Date: Tue, 29 Aug 2017 23:53:50 +0000 (-0400)
Subject: fix undefined behavior in memset due to missing sequence points
X-Git-Tag: v1.1.17~25
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9d4c902c42b3fda368d7ea64bb9575c46228fa7f;p=musl

fix undefined behavior in memset due to missing sequence points

patch by Pascal Cuoq.
---

diff --git a/src/string/memset.c b/src/string/memset.c
index f438b073..5613a148 100644
--- a/src/string/memset.c
+++ b/src/string/memset.c
@@ -11,12 +11,16 @@ void *memset(void *dest, int c, size_t n)
 	 * offsets are well-defined and in the dest region. */
 
 	if (!n) return dest;
-	s[0] = s[n-1] = c;
+	s[0] = c;
+	s[n-1] = c;
 	if (n <= 2) return dest;
-	s[1] = s[n-2] = c;
-	s[2] = s[n-3] = c;
+	s[1] = c;
+	s[2] = c;
+	s[n-2] = c;
+	s[n-3] = c;
 	if (n <= 6) return dest;
-	s[3] = s[n-4] = c;
+	s[3] = c;
+	s[n-4] = c;
 	if (n <= 8) return dest;
 
 	/* Advance pointer to align it at a 4-byte boundary,