From: Łukasz Langa <lukasz@langa.pl>
Date: Fri, 10 Feb 2017 08:14:55 +0000 (-0800)
Subject: Fix #29519: weakref spewing exceptions during interp finalization
X-Git-Tag: v3.6.1rc1~93^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9cd7e17640a49635d1c1f8c2989578a8fc2c1de6;p=python

Fix #29519: weakref spewing exceptions during interp finalization
---

diff --git a/Lib/weakref.py b/Lib/weakref.py
index aaebd0c464..787e33a327 100644
--- a/Lib/weakref.py
+++ b/Lib/weakref.py
@@ -106,7 +106,7 @@ class WeakValueDictionary(collections.MutableMapping):
         self, *args = args
         if len(args) > 1:
             raise TypeError('expected at most 1 arguments, got %d' % len(args))
-        def remove(wr, selfref=ref(self)):
+        def remove(wr, selfref=ref(self), _atomic_removal=_remove_dead_weakref):
             self = selfref()
             if self is not None:
                 if self._iterating:
@@ -114,7 +114,7 @@ class WeakValueDictionary(collections.MutableMapping):
                 else:
                     # Atomic removal is necessary since this function
                     # can be called asynchronously by the GC
-                    _remove_dead_weakref(d, wr.key)
+                    _atomic_removal(d, wr.key)
         self._remove = remove
         # A list of keys to be removed
         self._pending_removals = []
diff --git a/Misc/NEWS b/Misc/NEWS
index fa0e740836..e1b32add0e 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -23,6 +23,9 @@ Extension Modules
 Library
 -------
 
+- Issue #29519: Fix weakref spewing exceptions during interpreter shutdown
+  when used with a rare combination of multiprocessing and custom codecs.
+
 - Issue #29416: Prevent infinite loop in pathlib.Path.mkdir
 
 - Issue #29444: Fixed out-of-bounds buffer access in the group() method of