From: Neal Norwitz <nnorwitz@gmail.com>
Date: Sat, 12 Aug 2006 01:51:12 +0000 (+0000)
Subject: Move the assert which checks for a NULL pointer first.
X-Git-Tag: v2.5c1~79
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9cd3c34b6aaf189bd47849d0b0511234845940aa;p=python

Move the assert which checks for a NULL pointer first.
Klocwork #274.
---

diff --git a/Modules/collectionsmodule.c b/Modules/collectionsmodule.c
index 01a7ad057b..aef5d710c1 100644
--- a/Modules/collectionsmodule.c
+++ b/Modules/collectionsmodule.c
@@ -224,9 +224,9 @@ deque_popleft(dequeobject *deque, PyObject *unused)
 			deque->leftindex = CENTER + 1;
 			deque->rightindex = CENTER;
 		} else {
+			assert(deque->leftblock != NULL);
 			assert(deque->leftblock != deque->rightblock);
 			prevblock = deque->leftblock->rightlink;
-			assert(deque->leftblock != NULL);
 			PyMem_Free(deque->leftblock);
 			assert(prevblock != NULL);
 			prevblock->leftlink = NULL;