From: Sebastian Pipping <sebastian@pipping.org>
Date: Wed, 17 Jul 2019 16:05:17 +0000 (+0200)
Subject: runtests.c: Address cppcheck warning (fixes #283)
X-Git-Tag: R_2_2_8~75
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9c9d0d1a1fd8be1bea3e7df1a6647aa01b49e16e;p=libexpat

runtests.c: Address cppcheck warning (fixes #283)

[tests/runtests.c:647]: (error) Address of local auto-variable assigned to a function parameter.
---

diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c
index 5c2114ed..c0021a79 100644
--- a/expat/tests/runtests.c
+++ b/expat/tests/runtests.c
@@ -641,16 +641,18 @@ _run_ext_character_check(const char *text,
                          const XML_Char *expected,
                          const char *file, int line)
 {
-    CharData storage;
+    CharData * const storage = (CharData *)malloc(sizeof(CharData));
 
-    CharData_Init(&storage);
-    test_data->storage = &storage;
+    CharData_Init(storage);
+    test_data->storage = storage;
     XML_SetUserData(parser, test_data);
     XML_SetCharacterDataHandler(parser, ext_accumulate_characters);
     if (_XML_Parse_SINGLE_BYTES(parser, text, (int)strlen(text),
                                 XML_TRUE) == XML_STATUS_ERROR)
         _xml_failure(parser, file, line);
-    CharData_CheckXMLChars(&storage, expected);
+    CharData_CheckXMLChars(storage, expected);
+
+    free(storage);
 }
 
 #define run_ext_character_check(text, test_data, expected)               \