From: Tyson Andre Date: Tue, 3 Sep 2019 01:32:24 +0000 (-0400) Subject: Fix opcache return type for hash_update_stream X-Git-Tag: php-7.4.0RC1~3^2^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9c3b7ccda5e3737c779e019eb1468213edaa2e39;p=php Fix opcache return type for hash_update_stream It can return false if the resource type is wrong. ``` php > var_export(hash_update_stream(hash_init('md5'), imagecreate(1,1))); Warning: hash_update_stream(): supplied resource is not a valid stream resource in php shell code on line 1 false ``` The return types were initially added in c88ffa9a5673cb3141660626ba1921671f0b84d6 --- diff --git a/ext/opcache/Optimizer/zend_func_info.c b/ext/opcache/Optimizer/zend_func_info.c index 7395540bef..919b4c3a34 100644 --- a/ext/opcache/Optimizer/zend_func_info.c +++ b/ext/opcache/Optimizer/zend_func_info.c @@ -1192,7 +1192,7 @@ static const func_info_t func_infos[] = { F1("hash_hmac_file", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_STRING), F1("hash_init", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_OBJECT), F0("hash_update", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_TRUE), - F0("hash_update_stream", MAY_BE_NULL | MAY_BE_LONG), + F0("hash_update_stream", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_LONG), F0("hash_update_file", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_TRUE), F1("hash_final", MAY_BE_NULL | MAY_BE_STRING), F1("hash_copy", MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_OBJECT),