From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 24 Oct 2004 00:54:12 +0000 (+0000)
Subject: If we're going to test for switch validity by observing whether the
X-Git-Tag: REL8_0_0BETA4~12
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9b3fc492d36a3e215809535e90d402dbeee41966;p=postgresql

If we're going to test for switch validity by observing whether the
compiler emits any warnings, the test program had better be 100%
correct, not only 90% correct.  The recent addition of -Wold-style-definition
broke thread-safety detection on every platform that has that switch,
because the test program used an old-style definition.
---

diff --git a/config/acx_pthread.m4 b/config/acx_pthread.m4
index 5f9071056e..254a383a9b 100644
--- a/config/acx_pthread.m4
+++ b/config/acx_pthread.m4
@@ -134,8 +134,10 @@ for flag in $acx_pthread_flags; do
             # We find them by checking stderror.
             cat >conftest.$ac_ext <<_ACEOF
 int
-main ()
+main (int argc, char **argv)
 {
+  (void) argc;
+  (void) argv;
   return 0;
 }
 _ACEOF
diff --git a/configure b/configure
index 5eaa809ae8..a96ff78d0e 100755
--- a/configure
+++ b/configure
@@ -13606,8 +13606,10 @@ rm -f conftest.$ac_objext conftest$ac_exeext conftest.$ac_ext
             # We find them by checking stderror.
             cat >conftest.$ac_ext <<_ACEOF
 int
-main ()
+main (int argc, char **argv)
 {
+  (void) argc;
+  (void) argv;
   return 0;
 }
 _ACEOF