From: Richard Russon <rich@flatcap.org>
Date: Fri, 16 Feb 2018 14:21:24 +0000 (+0000)
Subject: disable the folder-hook for $record
X-Git-Tag: neomutt-20180223~2^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9b1f800048e37376786e5d88ef828b1a272b1b17;p=neomutt

disable the folder-hook for $record

It's possible to use $record to save an email to a different account.
The right thing to do is to call the `folder-hook` for the save folder,
save the email, then call the `folder-hook` for the 'current' folder.

Calling the hook this way causes problems for lots of people who have
commands in their hooks that are called when they didn't expect.

The hooks are left in the code wrapped in: `#ifdef RECORD_FOLDER_HOOK`
---

diff --git a/sendlib.c b/sendlib.c
index 792e3009d..39782c383 100644
--- a/sendlib.c
+++ b/sendlib.c
@@ -2948,7 +2948,9 @@ int mutt_write_fcc(const char *path, struct Header *hdr, const char *msgid,
   if (post)
     set_noconv_flags(hdr->content, 1);
 
+#ifdef RECORD_FOLDER_HOOK
   mutt_folder_hook(path);
+#endif
   if (mx_open_mailbox(path, MUTT_APPEND | MUTT_QUIET, &f) == NULL)
   {
     mutt_debug(1, "unable to open mailbox %s in append-mode, aborting.\n", path);
@@ -3139,10 +3141,12 @@ int mutt_write_fcc(const char *path, struct Header *hdr, const char *msgid,
     set_noconv_flags(hdr->content, 0);
 
 done:
+#ifdef RECORD_FOLDER_HOOK
   /* We ran a folder hook for the destination mailbox,
    * now we run it for the user's current mailbox */
   if (Context && Context->path)
     mutt_folder_hook(Context->path);
+#endif
 
   return rc;
 }