From: Florian Westphal <fw@strlen.de>
Date: Sun, 17 May 2009 19:32:53 +0000 (+0200)
Subject: conn.c: fix NumConnections imbalance
X-Git-Tag: rel-15-rc1~48
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9b1c47220fafeacda1e83b4732e1c8574062aac6;p=ngircd

conn.c: fix NumConnections imbalance

New_Server() can call Conn_Close() in its error paths,
but that function decrements the number of current active
connections. Thus we need to increment it earlier.
---

diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c
index 4c03877a..77a2bc19 100644
--- a/src/ngircd/conn.c
+++ b/src/ngircd/conn.c
@@ -1696,6 +1696,8 @@ New_Server( int Server , ng_ipaddr_t *dest)
 		return;
 	}
 
+	/* Conn_Close() decrements this counter again */
+	NumConnections++;
 	Client_SetIntroducer( c, c );
 	Client_SetToken( c, TOKEN_OUTBOUND );
 
@@ -1725,7 +1727,6 @@ New_Server( int Server , ng_ipaddr_t *dest)
 		return;
 	}
 #endif
-	NumConnections++;
 	LogDebug("Registered new connection %d on socket %d (%ld in total).",
 		 new_sock, My_Connections[new_sock].sock, NumConnections);
 	Conn_OPTION_ADD( &My_Connections[new_sock], CONN_ISCONNECTING );