From: Fariborz Jahanian <fjahanian@apple.com>
Date: Thu, 8 Mar 2012 00:52:24 +0000 (+0000)
Subject: improve on diagnostic when block captures uninitialized
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9ae3a3647388c42b91505b175c1c8d0055b637dd;p=clang

improve on diagnostic when block captures uninitialized
block variable. // rdar://10817031


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@152273 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index ec7a0597f1..07a94be54b 100644
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -1147,7 +1147,7 @@ def warn_uninit_byref_blockvar_captured_by_block : Warning<
   "block pointer variable %0 is uninitialized when captured by block">,
   InGroup<Uninitialized>, DefaultIgnore;
 def note_block_var_fixit_add_initialization : Note<
-  "consider using a '__block' variable %0 to silence this warning">;
+  "maybe you meant to use __block %0">;
 def note_var_fixit_add_initialization : Note<
   "initialize the variable %0 to silence this warning">;
 def err_init_incomplete_type : Error<"initialization of incomplete type %0">;
diff --git a/test/FixIt/fixit-recursive-block.c b/test/FixIt/fixit-recursive-block.c
index c1f69266b3..b276b417ac 100644
--- a/test/FixIt/fixit-recursive-block.c
+++ b/test/FixIt/fixit-recursive-block.c
@@ -5,7 +5,7 @@
 
 int main() {
     void (^arc_fail)() = ^() {  // expected-warning {{block pointer variable 'arc_fail' is uninitialized when captured by block}} \
-                                // expected-note {{consider using a '__block' variable 'arc_fail' to silence this warning}}
+                                // expected-note {{maybe you meant to use __block 'arc_fail'}}
        arc_fail(); // BOOM
     };
 }