From: Daniel Jasper Date: Fri, 19 Sep 2014 08:01:25 +0000 (+0000) Subject: clang-format: Undo r216377. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9aba614f0ebaf0fe2077be7e813fc7f05136978e;p=clang clang-format: Undo r216377. It has proven to not be a food idea in many case. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@218107 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Format/ContinuationIndenter.cpp b/lib/Format/ContinuationIndenter.cpp index 0dc65ba28e..ce6ebd84b6 100644 --- a/lib/Format/ContinuationIndenter.cpp +++ b/lib/Format/ContinuationIndenter.cpp @@ -867,10 +867,9 @@ void ContinuationIndenter::moveStatePastScopeOpener(LineState &State, getColumnLimit(State)) BreakBeforeParameter = true; } - bool NoLineBreak = - State.Stack.back().NoLineBreak || - ((Current.NestingLevel != 0 || Current.Type == TT_TemplateOpener) && - State.Stack.back().ContainsUnwrappedBuilder); + bool NoLineBreak = State.Stack.back().NoLineBreak || + (Current.Type == TT_TemplateOpener && + State.Stack.back().ContainsUnwrappedBuilder); State.Stack.push_back(ParenState(NewIndent, NewIndentLevel, State.Stack.back().LastSpace, AvoidBinPacking, NoLineBreak)); diff --git a/unittests/Format/FormatTest.cpp b/unittests/Format/FormatTest.cpp index 7da0b534be..93c58348a5 100644 --- a/unittests/Format/FormatTest.cpp +++ b/unittests/Format/FormatTest.cpp @@ -3831,12 +3831,9 @@ TEST_F(FormatTest, FormatsBuilderPattern) { " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); - // Prefer not to break after empty parentheses ... + // Prefer not to break after empty parentheses. verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" " First->LastNewlineOffset);"); - // ... unless nested. - verifyFormat("f(FirstToken->WhitespaceRange.getBegin()\n" - " .getLocWithOffset(First->LastNewlineOffset));"); } TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) {