From: Chris Lattner Date: Wed, 23 Jul 2008 06:53:34 +0000 (+0000) Subject: don't depend on the result of CreateNeg to be a binop X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9a847f598c4907a72b8593b364b9e6b94b086e75;p=clang don't depend on the result of CreateNeg to be a binop git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@53948 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGBuiltin.cpp b/lib/CodeGen/CGBuiltin.cpp index 9de5a5acd4..541a5664c8 100644 --- a/lib/CodeGen/CGBuiltin.cpp +++ b/lib/CodeGen/CGBuiltin.cpp @@ -103,10 +103,10 @@ RValue CodeGenFunction::EmitBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { case Builtin::BI__builtin_abs: { Value *ArgValue = EmitScalarExpr(E->getArg(0)); - llvm::BinaryOperator *NegOp = - Builder.CreateNeg(ArgValue, (ArgValue->getName() + "neg").c_str()); + Value *NegOp = Builder.CreateNeg(ArgValue, "neg"); Value *CmpResult = - Builder.CreateICmpSGE(ArgValue, NegOp->getOperand(0), "abscond"); + Builder.CreateICmpSGE(ArgValue, Constant::getNullValue(ArgValue->getType()), + "abscond"); Value *Result = Builder.CreateSelect(CmpResult, ArgValue, NegOp, "abs");