From: Noah Misch <noah@leadboat.com>
Date: Sun, 23 Jun 2019 19:02:19 +0000 (-0700)
Subject: Don't call PG_RETURN_BOOL() in a function not returning Datum.
X-Git-Tag: REL_12_BETA3~146
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9a81c9fa3f6a2f57b9db2a1ce5584c85fc1d977e;p=postgresql

Don't call PG_RETURN_BOOL() in a function not returning Datum.

This code is new in v12, and the defect probably was not user-visible.
---

diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c
index e5ac371fa0..853a8dc49a 100644
--- a/src/backend/utils/adt/timestamp.c
+++ b/src/backend/utils/adt/timestamp.c
@@ -5180,8 +5180,8 @@ TimestampTimestampTzRequiresRewrite(void)
 	long		offset;
 
 	if (pg_get_timezone_offset(session_timezone, &offset) && offset == 0)
-		PG_RETURN_BOOL(false);
-	PG_RETURN_BOOL(true);
+		return false;
+	return true;
 }
 
 /* timestamp_timestamptz()