From: Sriram Natarajan <srinatar@php.net>
Date: Tue, 5 Jan 2010 19:25:23 +0000 (+0000)
Subject: - Addressing minor leak noticed while addressing bug #48590
X-Git-Tag: php-5.4.0alpha1~191^2~2126
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9a1251eae7b431e1454d528575720f8b29964bcb;p=php

- Addressing minor leak noticed while addressing bug #48590
---

diff --git a/ext/soap/php_http.c b/ext/soap/php_http.c
index 68643c9ae8..866fa418f5 100644
--- a/ext/soap/php_http.c
+++ b/ext/soap/php_http.c
@@ -764,9 +764,9 @@ try_again:
 		smart_str_0(&soap_headers);
 
 		err = php_stream_write(stream, soap_headers.c, soap_headers.len);
+		smart_str_free(&soap_headers);
 		if (err != soap_headers.len) {
 			if (request != buf) {efree(request);}
-			smart_str_free(&soap_headers);
 			php_stream_close(stream);
 			if (client->url) {
 				php_url_free(client->url);
@@ -778,8 +778,6 @@ try_again:
 			smart_str_free(&soap_headers_z);
 			return FALSE;
 		}
-		smart_str_free(&soap_headers);
-
 	} else {
 		add_soap_fault(this_ptr, "HTTP", "Failed to create stream??", NULL, NULL TSRMLS_CC);
 		smart_str_free(&soap_headers_z);
@@ -1034,8 +1032,8 @@ try_again:
 				phpurl = new_url;
 
 				if (--redirect_max < 1) {
-					smart_str_free(&soap_headers_z);
 					add_soap_fault(this_ptr, "HTTP", "Redirection limit reached, aborting", NULL, NULL TSRMLS_CC);
+					smart_str_free(&soap_headers_z);
 					return FALSE;
 				}