From: George Rimar <grimar@accesssoftek.com>
Date: Fri, 26 Apr 2019 12:45:54 +0000 (+0000)
Subject: [yaml2obj] - Remove excessive variable. NFC.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=99defed408c4ec51e1c653c70c9332623ed548b5;p=llvm

[yaml2obj] - Remove excessive variable. NFC.

`auto &Strtab` was used only once.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359300 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/tools/yaml2obj/yaml2elf.cpp b/tools/yaml2obj/yaml2elf.cpp
index a35a9805a2e..bb5ca4ce86a 100644
--- a/tools/yaml2obj/yaml2elf.cpp
+++ b/tools/yaml2obj/yaml2elf.cpp
@@ -325,9 +325,9 @@ void ELFState<ELFT>::initSymtabSectionHeader(Elf_Shdr &SHeader,
   SHeader.sh_name = DotShStrtab.getOffset(IsStatic ? ".symtab" : ".dynsym");
   SHeader.sh_type = IsStatic ? ELF::SHT_SYMTAB : ELF::SHT_DYNSYM;
   SHeader.sh_link = IsStatic ? getDotStrTabSecNo() : getDotDynStrSecNo();
-  const auto &Symbols = IsStatic ? Doc.Symbols : Doc.DynamicSymbols;
-  auto &Strtab = IsStatic ? DotStrtab : DotDynstr;
+
   // One greater than symbol table index of the last local symbol.
+  const auto &Symbols = IsStatic ? Doc.Symbols : Doc.DynamicSymbols;
   SHeader.sh_info = findFirstNonGlobal(Symbols) + 1;
   SHeader.sh_entsize = sizeof(Elf_Sym);
   SHeader.sh_addralign = 8;
@@ -352,7 +352,7 @@ void ELFState<ELFT>::initSymtabSectionHeader(Elf_Shdr &SHeader,
     Syms.push_back(Sym);
   }
 
-  addSymbols(Symbols, Syms, Strtab);
+  addSymbols(Symbols, Syms, IsStatic ? DotStrtab : DotDynstr);
 
   writeArrayData(
       CBA.getOSAndAlignedOffset(SHeader.sh_offset, SHeader.sh_addralign),