From: Marcello Maggioni Date: Sat, 14 Jan 2017 07:28:47 +0000 (+0000) Subject: Removing potentially error-prone fallthrough. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=99dc11c1660e1e95dab95419166f305024e7289f;p=llvm Removing potentially error-prone fallthrough. NFC This fallthrough if other cases are added between fabs and default could cause fabs to fall to the next case resulting in a bug. Better getting rid of it immediately just to be sure. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@292003 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/InstructionSimplify.cpp b/lib/Analysis/InstructionSimplify.cpp index 796e6e44498..6c731c30c4c 100644 --- a/lib/Analysis/InstructionSimplify.cpp +++ b/lib/Analysis/InstructionSimplify.cpp @@ -4267,6 +4267,7 @@ static Value *SimplifyIntrinsic(Function *F, IterTy ArgBegin, IterTy ArgEnd, case Intrinsic::fabs: { if (SignBitMustBeZero(*ArgBegin, Q.TLI)) return *ArgBegin; + return nullptr; } default: return nullptr;