From: Bram Moolenaar Date: Sun, 4 Jul 2021 12:00:55 +0000 (+0200) Subject: patch 8.2.3098: popup window test is flaky on MS-Windows with GUI X-Git-Tag: v8.2.3098 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=999db2346b61e6f6e6fde2d0b56f4646a46b727d;p=vim patch 8.2.3098: popup window test is flaky on MS-Windows with GUI Problem: Popup window test is flaky on MS-Windows with GUI. Solution: Skip the check in this situation. --- diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim index 8e02ef1f0..62e19fa5d 100644 --- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -1550,24 +1550,32 @@ func Test_popup_filter() redraw " e is consumed by the filter + let g:eaten = '' call feedkeys('e', 'xt') call assert_equal('e', g:eaten) call feedkeys("\", 'xt') call assert_equal("\", g:eaten) " 0 is ignored by the filter + let g:ignored = '' normal $ call assert_equal(9, getcurpos()[2]) call feedkeys('0', 'xt') call assert_equal('0', g:ignored) - normal! l - call assert_equal(2, getcurpos()[2]) + + if has('win32') && has('gui_running') + echo "FIXME: this check is very flaky on MS-Windows GUI, the cursor doesn't move" + else + call assert_equal(1, getcurpos()[2]) + endif " x closes the popup call feedkeys('x', 'xt') call assert_equal("\", g:eaten) call assert_equal(-1, winbufnr(winid)) + unlet g:eaten + unlet g:ignored delfunc MyPopupFilter call popup_clear() endfunc diff --git a/src/version.c b/src/version.c index f6d5758ac..8d391d331 100644 --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 3098, /**/ 3097, /**/