From: Niels Provos <provos@gmail.com>
Date: Tue, 27 Feb 2007 08:16:50 +0000 (+0000)
Subject: missing return (-1) for failures on make_socket
X-Git-Tag: release-2.0.1-alpha~640
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=995a58a374c4b1ce28c214d22dfdf00329b28957;p=libevent

missing return (-1) for failures on make_socket


svn:r338
---

diff --git a/http.c b/http.c
index 7e9e7d94..6ff181de 100644
--- a/http.c
+++ b/http.c
@@ -2261,7 +2261,7 @@ static int
 make_socket(int should_bind, const char *address, u_short port)
 {
 	int fd;
-        struct addrinfo ai, *aitop;
+        struct addrinfo ai, *aitop = NULL;
 #ifdef HAVE_GETADDRINFO
         char strport[NI_MAXSERV];
         int ai_result;
@@ -2276,6 +2276,7 @@ make_socket(int should_bind, const char *address, u_short port)
                         event_warn("getaddrinfo");
                 else
                         event_warnx("getaddrinfo: %s", gai_strerror(ai_result));
+		return (-1);
         }
 #else
 	if (fake_getaddrinfo(address, &ai) < 0) {