From: Victor Stinner <victor.stinner@gmail.com>
Date: Thu, 17 Jul 2014 21:49:11 +0000 (+0200)
Subject: Issue #21247: Fix a race condition in test_send_signal() of asyncio
X-Git-Tag: v3.4.2rc1~208
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=98fa332e334633d5559ff3963df0ab5c6108d8e1;p=python

Issue #21247: Fix a race condition in test_send_signal() of asyncio

Add a basic synchronization mechanism to wait until the child process is ready
before sending it a signal.
---

diff --git a/Lib/test/test_asyncio/test_subprocess.py b/Lib/test/test_asyncio/test_subprocess.py
index d050458e7f..5425d9bfd5 100644
--- a/Lib/test/test_asyncio/test_subprocess.py
+++ b/Lib/test/test_asyncio/test_subprocess.py
@@ -108,11 +108,22 @@ class SubprocessMixin:
 
     @unittest.skipIf(sys.platform == 'win32', "Don't have SIGHUP")
     def test_send_signal(self):
-        args = PROGRAM_BLOCKED
-        create = asyncio.create_subprocess_exec(*args, loop=self.loop)
+        code = 'import time; print("sleeping", flush=True); time.sleep(3600)'
+        args = [sys.executable, '-c', code]
+        create = asyncio.create_subprocess_exec(*args, loop=self.loop, stdout=subprocess.PIPE)
         proc = self.loop.run_until_complete(create)
-        proc.send_signal(signal.SIGHUP)
-        returncode = self.loop.run_until_complete(proc.wait())
+
+        @asyncio.coroutine
+        def send_signal(proc):
+            # basic synchronization to wait until the program is sleeping
+            line = yield from proc.stdout.readline()
+            self.assertEqual(line, b'sleeping\n')
+
+            proc.send_signal(signal.SIGHUP)
+            returncode = (yield from proc.wait())
+            return returncode
+
+        returncode = self.loop.run_until_complete(send_signal(proc))
         self.assertEqual(-signal.SIGHUP, returncode)
 
     def prepare_broken_pipe_test(self):