From: Matteo Beccati <mbeccati@php.net>
Date: Sat, 28 Mar 2009 03:11:39 +0000 (+0000)
Subject: - Reverting: pcntl_signal() returning NULL when passing wrong parameters
X-Git-Tag: php-5.4.0alpha1~191^2~4031
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=98bafbbd677bc00a13b3f796c7a83147fb7b825b;p=php

- Reverting: pcntl_signal() returning NULL when passing wrong parameters
# Wow, my first commit and I broke something, sorry about that :(
---

diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c
index b9d64d95ef..414446a049 100755
--- a/ext/pcntl/pcntl.c
+++ b/ext/pcntl/pcntl.c
@@ -757,7 +757,7 @@ PHP_FUNCTION(pcntl_signal)
 	zend_bool restart_syscalls = 1;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "lz|b", &signo, &handle, &restart_syscalls) == FAILURE) {
-		RETURN_FALSE;
+		return;
 	}
 
 	if (!PCNTL_G(spares)) {
diff --git a/ext/pcntl/tests/pcntl_signal.phpt b/ext/pcntl/tests/pcntl_signal.phpt
index 324cc0b418..977f26fbcc 100644
--- a/ext/pcntl/tests/pcntl_signal.phpt
+++ b/ext/pcntl/tests/pcntl_signal.phpt
@@ -25,7 +25,7 @@ echo "ok\n";
 signal dispatched
 
 Warning: pcntl_signal() expects at least 2 parameters, 0 given in %s
-bool(false)
+NULL
 bool(true)
 
 Warning: pcntl_signal(): Invalid value for handle argument specified in %s