From: Anders Carlsson <andersca@mac.com>
Date: Wed, 3 Dec 2008 05:51:23 +0000 (+0000)
Subject: If a global var decl has an initializer, make sure to always set its linkage to external.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=98883e1e699457697fb8d5ac6d175dd3ee078774;p=clang

If a global var decl has an initializer, make sure to always set its linkage to external.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@60462 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index f0aa8b7d14..80ef53f5f9 100644
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -607,6 +607,8 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D) {
     case VarDecl::None:
       if (!D->getInit())
         GV->setLinkage(llvm::GlobalVariable::CommonLinkage);
+      else
+        GV->setLinkage(llvm::GlobalVariable::ExternalLinkage);
       break;
     case VarDecl::Extern:
     case VarDecl::PrivateExtern:
diff --git a/test/CodeGen/global-init.c b/test/CodeGen/global-init.c
new file mode 100644
index 0000000000..133a3b5373
--- /dev/null
+++ b/test/CodeGen/global-init.c
@@ -0,0 +1,7 @@
+// RUN: clang -emit-llvm -o - %s | not grep "common"
+
+// This checks that the global won't be marked as common. 
+// (It shouldn't because it's being initialized).
+
+int a;
+int a = 242;