From: Kristján Valur Jónsson <kristjan@ccpgames.com>
Date: Mon, 2 Apr 2012 15:23:29 +0000 (+0000)
Subject: Issue #14471: Fix a possible buffer overrun in the winreg module.
X-Git-Tag: v3.3.0a3~333^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=984dfa7eed5a2c4673a5cc108f6bad1401e83440;p=python

Issue #14471: Fix a possible buffer overrun in the winreg module.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 3d9b8225bd..18a8d73e69 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -34,6 +34,8 @@ Core and Builtins
 - Issue #13521: dict.setdefault() now does only one lookup for the given key,
   making it "atomic" for many purposes.  Patch by Filip Gruszczyński.
 
+- Issue #14471: Fix a possible buffer overrun in the winreg module.
+
 Library
 -------
 
diff --git a/PC/winreg.c b/PC/winreg.c
index 1bc47b958b..240ca69c39 100644
--- a/PC/winreg.c
+++ b/PC/winreg.c
@@ -1110,7 +1110,7 @@ PyEnumKey(PyObject *self, PyObject *args)
      * nul.  RegEnumKeyEx requires a 257 character buffer to
      * retrieve such a key name. */
     wchar_t tmpbuf[257];
-    DWORD len = sizeof(tmpbuf); /* includes NULL terminator */
+    DWORD len = sizeof(tmpbuf)/sizeof(wchar_t); /* includes NULL terminator */
 
     if (!PyArg_ParseTuple(args, "Oi:EnumKey", &obKey, &index))
         return NULL;