From: Daniel Dunbar Date: Mon, 23 Feb 2009 17:26:39 +0000 (+0000) Subject: Add low level support for generating invoke instead of calls. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9834ffbe54788239c8361d3cfe5826fd277ddfb2;p=clang Add low level support for generating invoke instead of calls. - No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@65325 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGCall.cpp b/lib/CodeGen/CGCall.cpp index db5085aaab..8f4367c858 100644 --- a/lib/CodeGen/CGCall.cpp +++ b/lib/CodeGen/CGCall.cpp @@ -1517,7 +1517,6 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI, } if (FuncAttrs) PAL.push_back(llvm::AttributeWithIndex::get(~0, FuncAttrs)); - } void CodeGenFunction::EmitFunctionProlog(const CGFunctionInfo &FI, @@ -1763,26 +1762,46 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, break; } } - - llvm::CallInst *CI = Builder.CreateCall(Callee,&Args[0],&Args[0]+Args.size()); + llvm::BasicBlock *InvokeDest = getInvokeDest(); CodeGen::AttributeListType AttributeList; CGM.ConstructAttributeList(CallInfo, TargetDecl, AttributeList); - CI->setAttributes(llvm::AttrListPtr::get(AttributeList.begin(), - AttributeList.size())); + llvm::AttrListPtr Attrs = llvm::AttrListPtr::get(AttributeList.begin(), + AttributeList.end()); - if (const llvm::Function *F = dyn_cast(Callee)) - CI->setCallingConv(F->getCallingConv()); + llvm::Instruction *CI; + if (!InvokeDest || Attrs.getFnAttributes() & (llvm::Attribute::NoUnwind || + llvm::Attribute::NoReturn)) { + llvm::CallInst *CallInstr = + Builder.CreateCall(Callee, &Args[0], &Args[0]+Args.size()); + CI = CallInstr; + + CallInstr->setAttributes(Attrs); + if (const llvm::Function *F = dyn_cast(Callee)) + CallInstr->setCallingConv(F->getCallingConv()); + + // If the call doesn't return, finish the basic block and clear the + // insertion point; this allows the rest of IRgen to discard + // unreachable code. + if (CallInstr->doesNotReturn()) { + Builder.CreateUnreachable(); + Builder.ClearInsertionPoint(); + + // Return a reasonable RValue. + return GetUndefRValue(RetTy); + } + } else { + llvm::BasicBlock *Cont = createBasicBlock("invoke.cont"); + llvm::InvokeInst *InvokeInstr = + Builder.CreateInvoke(Callee, Cont, InvokeDest, + &Args[0], &Args[0]+Args.size()); + CI = InvokeInstr; - // If the call doesn't return, finish the basic block and clear the - // insertion point; this allows the rest of IRgen to discard - // unreachable code. - if (CI->doesNotReturn()) { - Builder.CreateUnreachable(); - Builder.ClearInsertionPoint(); + InvokeInstr->setAttributes(Attrs); + if (const llvm::Function *F = dyn_cast(Callee)) + InvokeInstr->setCallingConv(F->getCallingConv()); - // Return a reasonable RValue. - return GetUndefRValue(RetTy); + EmitBlock(Cont); } if (CI->getType() != llvm::Type::VoidTy) diff --git a/lib/CodeGen/CodeGenFunction.cpp b/lib/CodeGen/CodeGenFunction.cpp index 9175d16063..ccd961ac28 100644 --- a/lib/CodeGen/CodeGenFunction.cpp +++ b/lib/CodeGen/CodeGenFunction.cpp @@ -25,7 +25,7 @@ using namespace CodeGen; CodeGenFunction::CodeGenFunction(CodeGenModule &cgm) : CGM(cgm), Target(CGM.getContext().Target), DebugInfo(0), SwitchInsn(0), - CaseRangeBlock(0) { + CaseRangeBlock(0), InvokeDest(0) { LLVMIntTy = ConvertType(getContext().IntTy); LLVMPointerWidth = Target.getPointerWidth(0); diff --git a/lib/CodeGen/CodeGenFunction.h b/lib/CodeGen/CodeGenFunction.h index 8bda453ee7..b3d6a327eb 100644 --- a/lib/CodeGen/CodeGenFunction.h +++ b/lib/CodeGen/CodeGenFunction.h @@ -190,6 +190,10 @@ private: /// statement range in current switch instruction. llvm::BasicBlock *CaseRangeBlock; + /// InvokeDest - This is the nearest exception target for calls + /// which can unwind, when exceptions are being used. + llvm::BasicBlock *InvokeDest; + // VLASizeMap - This keeps track of the associated size for each VLA type. // FIXME: Maybe this could be a stack of maps that is pushed/popped as we // enter/leave scopes. @@ -233,6 +237,13 @@ public: ASTContext &getContext() const; CGDebugInfo *getDebugInfo() { return DebugInfo; } + llvm::BasicBlock *getInvokeDest() { return InvokeDest; } + void setInvokeDest(llvm::BasicBlock *B) { InvokeDest = B; } + + //===--------------------------------------------------------------------===// + // Objective-C + //===--------------------------------------------------------------------===// + void GenerateObjCMethod(const ObjCMethodDecl *OMD); void StartObjCMethod(const ObjCMethodDecl *MD,