From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Tue, 23 Jul 2013 21:38:32 +0000 (-0400)
Subject: Check for NULL result from strdup
X-Git-Tag: REL9_2_5~40
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=980c24e1e80223ccd70e50d9d64c2b38cf50879e;p=postgresql

Check for NULL result from strdup

Per Coverity Scan
---

diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index b1ad776a23..30182958a1 100644
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -1132,7 +1132,17 @@ initialize_SSL(PGconn *conn)
 		{
 			/* Colon, but not in second character, treat as engine:key */
 			char	   *engine_str = strdup(conn->sslkey);
-			char	   *engine_colon = strchr(engine_str, ':');
+			char	   *engine_colon;
+
+			if (engine_str == NULL)
+			{
+				printfPQExpBuffer(&conn->errorMessage,
+								  libpq_gettext("out of memory\n"));
+				return -1;
+			}
+
+			/* cannot return NULL because we already checked before strdup */
+			engine_colon = strchr(engine_str, ':');
 
 			*engine_colon = '\0';		/* engine_str now has engine name */
 			engine_colon++;		/* engine_colon now has key name */