From: Andrew Dunstan <andrew@dunslane.net>
Date: Fri, 1 Mar 2019 19:11:37 +0000 (-0500)
Subject: Remove tests for pg_dumpall --exclude-database missing argument
X-Git-Tag: REL_12_BETA1~639
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=97b6f2eb759ce898ad632fd7b5db29f542b93454;p=postgresql

Remove tests for pg_dumpall --exclude-database missing argument

It turns out that different getopt implementations spell the error for
missing arguments different ways. This test is of fairly marginal
value, so instead of trying to keep up  with the different error
messages just remove the test.
---

diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 59b77214c6..1dad553739 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -4,7 +4,7 @@ use warnings;
 use Config;
 use PostgresNode;
 use TestLib;
-use Test::More tests => 74;
+use Test::More tests => 72;
 
 my $tempdir       = TestLib::tempdir;
 my $tempdir_short = TestLib::tempdir_short;
@@ -151,11 +151,6 @@ command_fails_like(
 	'pg_restore: options -C\/--create and -1\/--single-transaction cannot be used together'
 );
 
-command_fails_like(
-	[ 'pg_dumpall', '--exclude-database' ],
-	qr/\Qpg_dumpall: option '--exclude-database' requires an argument\E/,
-	'pg_dumpall: option --exclude-database requires an argument');
-
 # also fails for -r and -t, but it seems pointless to add more tests for those.
 command_fails_like(
 	[ 'pg_dumpall', '--exclude-database=foo', '--globals-only' ],