From: Nikita Popov <nikita.ppv@gmail.com>
Date: Mon, 9 Sep 2019 15:11:22 +0000 (+0200)
Subject: Clarify that our usage of gettimeofday() is infallible
X-Git-Tag: php-7.4.0RC2~65
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=974e77b3458271d0bf55182935b6178c4fe20656;p=php

Clarify that our usage of gettimeofday() is infallible

And that false can't be returned for this reason.
---

diff --git a/ext/standard/microtime.c b/ext/standard/microtime.c
index 46d1a7b278..9bd45e188d 100644
--- a/ext/standard/microtime.c
+++ b/ext/standard/microtime.c
@@ -57,7 +57,7 @@ static void _php_gettimeofday(INTERNAL_FUNCTION_PARAMETERS, int mode)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (gettimeofday(&tp, NULL)) {
-		RETURN_FALSE;
+		ZEND_ASSERT(0 && "gettimeofday() can't fail");
 	}
 
 	if (get_as_float) {