From: dirk <dirk@git.imagemagick.org>
Date: Sat, 25 Jul 2015 19:23:33 +0000 (+0000)
Subject: Removed IfStringTrue, IsMagickNULL and IsMagickNotNULL
X-Git-Tag: 7.0.1-0~754
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=972c2e42a2171341bbf55a48cb36882616a591b1;p=imagemagick

Removed IfStringTrue, IsMagickNULL and IsMagickNotNULL
---

diff --git a/MagickCore/delegate.c b/MagickCore/delegate.c
index 908556698..7f47f2245 100644
--- a/MagickCore/delegate.c
+++ b/MagickCore/delegate.c
@@ -996,7 +996,7 @@ static MagickBooleanType IsDelegateCacheInstantiated(ExceptionInfo *exception)
         delegate_cache=AcquireDelegateCache(DelegateFilename,exception);
       UnlockSemaphoreInfo(delegate_semaphore);
     }
-  return(IsMagickNotNULL(delegate_cache));
+  return(delegate_cache != (LinkedListInfo *) NULL ? MagickTrue : MagickFalse);
 }
 
 /*
diff --git a/MagickCore/distort.c b/MagickCore/distort.c
index 0d92b3586..2ec1cd609 100644
--- a/MagickCore/distort.c
+++ b/MagickCore/distort.c
@@ -1956,7 +1956,7 @@ MagickExport Image *DistortImage(const Image *image,DistortImageMethod method,
   }
 
   /* Verbose output */
-  if ( IfStringTrue(GetImageArtifact(image,"verbose")) ) {
+  if (IsStringTrue(GetImageArtifact(image,"verbose")) != MagickFalse) {
     register ssize_t
        i;
     char image_gen[MagickPathExtent];
@@ -2943,7 +2943,7 @@ MagickExport Image *SparseColorImage(const Image *image,
   }
 
   /* Verbose output */
-  if ( IfStringTrue(GetImageArtifact(image,"verbose")) ) {
+  if (IsStringTrue(GetImageArtifact(image,"verbose")) != MagickFalse) {
 
     switch (sparse_method) {
       case BarycentricColorInterpolate:
diff --git a/MagickCore/magick-type.h b/MagickCore/magick-type.h
index da553bd3d..20de3bfc6 100644
--- a/MagickCore/magick-type.h
+++ b/MagickCore/magick-type.h
@@ -161,8 +161,6 @@ typedef enum
    IsMagickTrue()     converts a C integer boolean to a MagickBooleanType
    IsMagickFalse()    converts and is also a MagickBooleanType 'not' operation
 
-   IsMagickNULL()
-   IsMagickNotNULL()  converts C pointers tests MagickBooleanType
 */
 #if 1
 /* Fast C typing method assumes MagickBooleanType match 0,1 values */
@@ -179,9 +177,6 @@ typedef enum
 #  define IsMagickFalse(v) ((v)?MagickFalse:MagickTrue)
 #  define IsMagickNot(v)   (IfMagickTrue(v)?MagickFalse:MagickTrue)
 #endif
-#define IfStringTrue(v)       IfMagickTrue(IsStringTrue(v))
-#define IsMagickNULL(v)       (((void *)(v) == NULL)?MagickTrue:MagickFalse)
-#define IsMagickNotNULL(v)    (((void *)(v) != NULL)?MagickTrue:MagickFalse)
 
 /*
   The IsNaN and IfNan tests for special floating point numbers of
diff --git a/MagickCore/morphology.c b/MagickCore/morphology.c
index b375168cd..972f1482d 100644
--- a/MagickCore/morphology.c
+++ b/MagickCore/morphology.c
@@ -4086,13 +4086,13 @@ exit_cleanup:
 %
 %  User defined settings include...
 %    * Output Bias for Convolution and correlation ("-define convolve:bias=??")
-%    * Kernel Scale/normalize settings             ("-define convolve:scale=??")
+%    * Kernel Scale/normalize settings            ("-define convolve:scale=??")
 %      This can also includes the addition of a scaled unity kernel.
-%    * Show Kernel being applied                   ("-define showkernel=1")
+%    * Show Kernel being applied            ("-define morphology:showkernel=1")
 %
 %  Other operators that do not want user supplied options interfering,
-%  especially "convolve:bias" and "showkernel" should use MorphologyApply()
-%  directly.
+%  especially "convolve:bias" and "morphology:showkernel" should use
+%  MorphologyApply() directly.
 %
 %  The format of the MorphologyImage method is:
 %
@@ -4120,17 +4120,20 @@ MagickExport Image *MorphologyImage(const Image *image,
   const MorphologyMethod method,const ssize_t iterations,
   const KernelInfo *kernel,ExceptionInfo *exception)
 {
-  KernelInfo
-    *curr_kernel;
+  const char
+    *artifact;
 
   CompositeOperator
     compose;
 
+  double
+    bias;
+
   Image
     *morphology_image;
 
-  double
-    bias;
+  KernelInfo
+    *curr_kernel;
 
   curr_kernel = (KernelInfo *) kernel;
   bias=0.0;
@@ -4173,9 +4176,8 @@ MagickExport Image *MorphologyImage(const Image *image,
     }
 
   /* display the (normalized) kernel via stderr */
-  if ( IfStringTrue(GetImageArtifact(image,"showkernel"))
-    || IfStringTrue(GetImageArtifact(image,"convolve:showkernel"))
-    || IfStringTrue(GetImageArtifact(image,"morphology:showkernel")) )
+  artifact=GetImageArtifact(image,"morphology:showkernel");
+  if (IsStringTrue(artifact) != MagickFalse)
     ShowKernelInfo(curr_kernel);
 
   /* Override the default handling of multi-kernel morphology results
@@ -4184,8 +4186,7 @@ MagickExport Image *MorphologyImage(const Image *image,
    * Otherwise merge resulting images using compose method given.
    * Default for 'HitAndMiss' is 'Lighten'.
    */
-  { const char
-      *artifact;
+  {
     ssize_t
       parse;
 
@@ -4629,7 +4630,8 @@ MagickExport void ScaleKernelInfo(KernelInfo *kernel,
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %
 %  ShowKernelInfo() outputs the details of the given kernel defination to
-%  standard error, generally due to a users 'showkernel' option request.
+%  standard error, generally due to a users 'morphology:showkernel' option
+%  request.
 %
 %  The format of the ShowKernel method is:
 %
diff --git a/MagickCore/resample.c b/MagickCore/resample.c
index b9fb95630..01cfeed35 100644
--- a/MagickCore/resample.c
+++ b/MagickCore/resample.c
@@ -1334,8 +1334,8 @@ MagickExport void SetResampleFilter(ResampleFilter *resample_filter,
   #pragma omp single
 #endif
   {
-    if (IfStringTrue(GetImageArtifact(resample_filter->image,
-             "resample:verbose")) )
+    if (IsStringTrue(GetImageArtifact(resample_filter->image,
+        "resample:verbose")) != MagickFalse)
       {
         register int
           Q;
diff --git a/MagickCore/resize.c b/MagickCore/resize.c
index b8741ff4c..1d290a12c 100644
--- a/MagickCore/resize.c
+++ b/MagickCore/resize.c
@@ -1117,7 +1117,7 @@ MagickPrivate ResizeFilter *AcquireResizeFilter(const Image *image,
   #pragma omp master
   {
 #endif
-    if (IfStringTrue(GetImageArtifact(image,"filter:verbose")))
+    if (IsStringTrue(GetImageArtifact(image,"filter:verbose")) != MagickFalse)
       {
         double
           support,