From: Bram Moolenaar <Bram@vim.org>
Date: Sun, 16 May 2021 22:22:06 +0000 (+0200)
Subject: patch 8.2.2863: removing a text property does not redraw optimally
X-Git-Tag: v8.2.2863
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=965c04486c9364ded99b49c86f4c41228503df1f;p=vim

patch 8.2.2863: removing a text property does not redraw optimally

Problem:    Removing a text property does not redraw optimally.
Solution:   Only redraw the lines that mithg actually have been changed.
---

diff --git a/src/textprop.c b/src/textprop.c
index 9a9dddce7..bd9a77cad 100644
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -815,6 +815,8 @@ f_prop_remove(typval_T *argvars, typval_T *rettv)
     linenr_T	start = 1;
     linenr_T	end = 0;
     linenr_T	lnum;
+    linenr_T	first_changed = 0;
+    linenr_T	last_changed = 0;
     dict_T	*dict;
     buf_T	*buf = curbuf;
     int		do_all;
@@ -925,6 +927,9 @@ f_prop_remove(typval_T *argvars, typval_T *rettv)
 		    buf->b_ml.ml_line_len -= sizeof(textprop_T);
 		    --idx;
 
+		    if (first_changed == 0)
+			first_changed = lnum;
+		    last_changed = lnum;
 		    ++rettv->vval.v_number;
 		    if (!do_all)
 			break;
@@ -932,15 +937,10 @@ f_prop_remove(typval_T *argvars, typval_T *rettv)
 	    }
 	}
     }
-    if (rettv->vval.v_number > 0)
+    if (first_changed > 0)
     {
-	if (start == 1 && end == buf->b_ml.ml_line_count)
-	    redraw_buf_later(buf, NOT_VALID);
-	else
-	{
-	    changed_lines_buf(buf, start, end + 1, 0);
-	    redraw_buf_later(buf, VALID);
-	}
+	changed_lines_buf(buf, first_changed, last_changed + 1, 0);
+	redraw_buf_later(buf, VALID);
     }
 }
 
diff --git a/src/version.c b/src/version.c
index b5401e624..cf5208ffc 100644
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2863,
 /**/
     2862,
 /**/