From: Adrian Prantl Date: Wed, 18 Sep 2013 22:08:57 +0000 (+0000) Subject: Debug info: Explicitly set the DIVariable::isIndirect() flag for VLAs. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=95d3d1a9b2e5177d793f04cebfd1df01a435df44;p=clang Debug info: Explicitly set the DIVariable::isIndirect() flag for VLAs. This allows us to get rid of an ugly hack in the backend. Paired commit with LLVM. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@190960 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGDebugInfo.cpp b/lib/CodeGen/CGDebugInfo.cpp index 0069d577f2..23b73a31f0 100644 --- a/lib/CodeGen/CGDebugInfo.cpp +++ b/lib/CodeGen/CGDebugInfo.cpp @@ -2747,6 +2747,8 @@ void CGDebugInfo::EmitDeclare(const VarDecl *VD, unsigned Tag, DBuilder.insertDeclare(Storage, D, Builder.GetInsertBlock()); Call->setDebugLoc(llvm::DebugLoc::get(Line, Column, Scope)); return; + } else if (isa(VD->getType())) { + Flags |= llvm::DIDescriptor::FlagIndirectVariable; } } else if (const RecordType *RT = dyn_cast(VD->getType())) { // If VD is an anonymous union then Storage represents value for diff --git a/test/CodeGen/debug-info-vla.c b/test/CodeGen/debug-info-vla.c index 2e173e4a3f..7a8da960db 100644 --- a/test/CodeGen/debug-info-vla.c +++ b/test/CodeGen/debug-info-vla.c @@ -2,7 +2,7 @@ void testVLAwithSize(int s) { -// CHECK: metadata !{i32 {{.*}}, metadata {{.*}}, metadata !"vla", metadata {{.*}}, i32 [[@LINE+1]], metadata {{.*}}, i32 0, i32 0} ; [ DW_TAG_auto_variable ] [vla] [line [[@LINE+1]]] +// CHECK: metadata !{i32 {{.*}}, metadata {{.*}}, metadata !"vla", metadata {{.*}}, i32 [[@LINE+1]], metadata {{.*}}, i32 8192, i32 0} ; [ DW_TAG_auto_variable ] [vla] [line [[@LINE+1]]] int vla[s]; int i; for (i = 0; i < s; i++) {