From: Nguyễn Thái Ngọc Duy Date: Fri, 11 Jan 2013 03:09:59 +0000 (+0700) Subject: clone: forbid --bare --separate-git-dir X-Git-Tag: v1.8.2-rc0~106^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=95b63f1ebb1d2b1ae34238cac331dd1e6e437975;p=git clone: forbid --bare --separate-git-dir The --separate-git-dir option was introduced to make it simple to put the git directory somewhere outside the worktree, for example when cloning a repository for use as a submodule. It was not intended for use when creating a bare repository. In that case there is no worktree and it is more natural to directly clone the repository and create a .git file as separate steps: git clone --bare /path/to/repo.git bar.git printf 'gitdir: bar.git\n' >foo.git Forbid the combination, making the command easier to explain. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- diff --git a/builtin/clone.c b/builtin/clone.c index 0d663e34f7..b66766f8c9 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -704,6 +704,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix) if (option_origin) die(_("--bare and --origin %s options are incompatible."), option_origin); + if (real_git_dir) + die(_("--bare and --separate-git-dir are incompatible.")); option_no_checkout = 1; }