From: Bram Moolenaar <Bram@vim.org>
Date: Thu, 9 Dec 2021 18:42:57 +0000 (+0000)
Subject: patch 8.2.3768: timer_info() has the wrong repeat value in a timer callback
X-Git-Tag: v8.2.3768
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=95b2dd0c008f0977ebb3cbe233a5064001a332e1;p=vim

patch 8.2.3768: timer_info() has the wrong repeat value in a timer callback

Problem:    timer_info() has the wrong repeat value in a timer callback.
Solution:   Do not add one to the repeat value when in the callback.
            (closes #9294)
---

diff --git a/src/testdir/test_timers.vim b/src/testdir/test_timers.vim
index 865a03b6d..c833dd837 100644
--- a/src/testdir/test_timers.vim
+++ b/src/testdir/test_timers.vim
@@ -117,6 +117,13 @@ func Test_timer_info()
   call assert_equal([], timer_info(id))
 
   call assert_fails('call timer_info("abc")', 'E39:')
+
+  " check repeat count inside the callback
+  let g:timer_repeat = []
+  let tid = timer_start(10, {tid -> execute("call add(g:timer_repeat, timer_info(tid)[0].repeat)")}, #{repeat: 3})
+  sleep 100m
+  call assert_equal([2, 1, 0], g:timer_repeat)
+  unlet g:timer_repeat
 endfunc
 
 func Test_timer_stopall()
diff --git a/src/time.c b/src/time.c
index 362fd4645..bb4a20282 100644
--- a/src/time.c
+++ b/src/time.c
@@ -696,7 +696,8 @@ add_timer_info(typval_T *rettv, timer_T *timer)
     dict_add_number(dict, "remaining", (long)remaining);
 
     dict_add_number(dict, "repeat",
-		    (long)(timer->tr_repeat < 0 ? -1 : timer->tr_repeat + 1));
+	    (long)(timer->tr_repeat < 0 ? -1
+			     : timer->tr_repeat + (timer->tr_firing ? 0 : 1)));
     dict_add_number(dict, "paused", (long)(timer->tr_paused));
 
     di = dictitem_alloc((char_u *)"callback");
diff --git a/src/version.c b/src/version.c
index c3e34e4a9..473b93443 100644
--- a/src/version.c
+++ b/src/version.c
@@ -753,6 +753,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    3768,
 /**/
     3767,
 /**/