From: Victor Stinner <victor.stinner@haypocalc.com>
Date: Mon, 22 Mar 2010 12:24:37 +0000 (+0000)
Subject: Issue #1583863: An unicode subclass can now override the __str__ method
X-Git-Tag: v2.7b1~261
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=95affc44495806a540f4d997d13361cc388b1a7e;p=python

Issue #1583863: An unicode subclass can now override the __str__ method
---

diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
index a859c0faa7..973a00870f 100644
--- a/Lib/test/test_unicode.py
+++ b/Lib/test/test_unicode.py
@@ -1193,6 +1193,17 @@ class UnicodeTest(
         self.assertRaises(MemoryError, alloc)
         self.assertRaises(MemoryError, alloc)
 
+    def test_format_subclass(self):
+        class U(unicode):
+            def __str__(self):
+                return '__str__ overridden'
+            def __unicode__(self):
+                return u'__unicode__ overridden'
+        u = U(u'xxx')
+        self.assertEquals("%s" % u, u'__unicode__ overridden')
+        self.assertEquals("{}".format(u), u'__unicode__ overridden')
+
+
 def test_main():
     test_support.run_unittest(__name__)
 
diff --git a/Misc/NEWS b/Misc/NEWS
index f93486ef7d..dd61f4f64c 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,8 @@ What's New in Python 2.7 beta 1?
 Core and Builtins
 -----------------
 
+- Issue #1583863: An unicode subclass can now override the __str__ method
+
 - Issue #6474: Make error message from passing an inadequate number of keyword
   arguments to a function correct.
 
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 113a460e27..82af3a21f5 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -8466,7 +8466,7 @@ PyObject *PyUnicode_Format(PyObject *format,
 
             case 's':
             case 'r':
-                if (PyUnicode_Check(v) && c == 's') {
+                if (PyUnicode_CheckExact(v) && c == 's') {
                     temp = v;
                     Py_INCREF(temp);
                 }