From: Ted Kremenek Date: Thu, 21 Feb 2013 22:10:49 +0000 (+0000) Subject: Remove superfluous null pointer check. The pointer is used prior to this check. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=94f3f549a7e0c426d5ffda7f25d1983c885dab9c;p=clang Remove superfluous null pointer check. The pointer is used prior to this check. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@175807 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index 7411e809db..65bdd2a47f 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -1672,14 +1672,13 @@ bool Sema::DiagnoseEmptyLookup(Scope *S, CXXScopeSpec &SS, LookupResult &R, << SS.getRange() << FixItHint::CreateReplacement(Corrected.getCorrectionRange(), CorrectedStr); - if (ND) { - unsigned diag = isa(ND) - ? diag::note_implicit_param_decl - : diag::note_previous_decl; - Diag(ND->getLocation(), diag) - << CorrectedQuotedStr; - } + unsigned diag = isa(ND) + ? diag::note_implicit_param_decl + : diag::note_previous_decl; + + Diag(ND->getLocation(), diag) + << CorrectedQuotedStr; // Tell the callee to try to recover. return false;