From: Eric Covener <covener@apache.org>
Date: Sat, 25 Oct 2014 17:45:30 +0000 (+0000)
Subject: fix another case of 304 response sent to an unconditional request
X-Git-Tag: 2.5.0-alpha~3750
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=94c4cc461f7d7d032198a8a53fd2e57fbaf68618;p=apache

fix another case of 304 response sent to an unconditional request



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1634237 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/CHANGES b/CHANGES
index 1af338b61d..150dde4c07 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.0
-
+ 
+  *) mod_cache: Avoid a 304 response to an unconditional requst when an AH00752
+     CacheLock error occurs during cache revalidation. [Eric Covener]
+     
   *) mod_proxy: Use the correct server name for SNI in case the backend
      SSL connection itself is established via a proxy server.
      PR 57139 [Szabolcs Gyurko <szabolcs gyurko.org>]
diff --git a/modules/cache/mod_cache.c b/modules/cache/mod_cache.c
index 6d909f03d2..5f478cd876 100644
--- a/modules/cache/mod_cache.c
+++ b/modules/cache/mod_cache.c
@@ -234,6 +234,11 @@ static int cache_quick_handler(request_rec *r, int lookup)
                     ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv,
                             r, APLOGNO(00752) "Cache locked for url, not caching "
                             "response: %s", r->uri);
+                    /* cache_select() may have added conditional headers */
+                    if (cache->stale_headers) {
+                        r->headers_in = cache->stale_headers;
+                    }
+
                 }
             }
             else {