From: Azat Khuzhin <azat@libevent.org>
Date: Thu, 23 Jul 2020 20:38:53 +0000 (+0300)
Subject: Fix bufferevent_get_{openssl,mbedtls}_error()
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=948ad3043590a36db6c8299bf0fb00ac3e1235ef;p=libevent

Fix bufferevent_get_{openssl,mbedtls}_error()

The bufferevent_get_openssl_error() returns unsigned long, so returning
-1 on error in unclear. Let's use 0.

Fixes: #1028
---

diff --git a/bufferevent_mbedtls.c b/bufferevent_mbedtls.c
index c60b109c..1b59a532 100644
--- a/bufferevent_mbedtls.c
+++ b/bufferevent_mbedtls.c
@@ -290,7 +290,7 @@ bufferevent_get_mbedtls_error(struct bufferevent *bufev)
 {
 	struct bufferevent_ssl *bev_ssl = bufferevent_ssl_upcast(bufev);
 	if (!bev_ssl)
-		return -1;
+		return 0;
 	return bufferevent_get_ssl_error(bufev);
 }
 
diff --git a/bufferevent_openssl.c b/bufferevent_openssl.c
index c50c022d..2fb6c252 100644
--- a/bufferevent_openssl.c
+++ b/bufferevent_openssl.c
@@ -524,6 +524,6 @@ bufferevent_get_openssl_error(struct bufferevent *bufev)
 {
 	struct bufferevent_ssl *bev_ssl = bufferevent_ssl_upcast(bufev);
 	if (!bev_ssl)
-		return -1;
+		return 0;
 	return bufferevent_get_ssl_error(bufev);
 }