From: Gor Nishanov Date: Wed, 28 Sep 2016 22:37:17 +0000 (+0000) Subject: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9455bc7a1d6fbd931257bb84df066ad5ba5c2c62;p=clang [Coroutines] Add proper mangling for operator co_await for MicrosoftABI Reviewers: rnk, rsmith Subscribers: mehdi_amini, cfe-commits Differential Revision: https://reviews.llvm.org/D25045 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@282645 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/MicrosoftMangle.cpp b/lib/AST/MicrosoftMangle.cpp index 479ac44aa0..1ff433bed0 100644 --- a/lib/AST/MicrosoftMangle.cpp +++ b/lib/AST/MicrosoftMangle.cpp @@ -1089,6 +1089,8 @@ void MicrosoftCXXNameMangler::mangleOperatorName(OverloadedOperatorKind OO, case OO_Array_New: Out << "?_U"; break; // ::= ?_V # delete[] case OO_Array_Delete: Out << "?_V"; break; + // ::= ?__L # co_await + case OO_Coawait: Out << "?__L"; break; case OO_Conditional: { DiagnosticsEngine &Diags = Context.getDiags(); @@ -1098,14 +1100,6 @@ void MicrosoftCXXNameMangler::mangleOperatorName(OverloadedOperatorKind OO, break; } - case OO_Coawait: { - DiagnosticsEngine &Diags = Context.getDiags(); - unsigned DiagID = Diags.getCustomDiagID(DiagnosticsEngine::Error, - "cannot mangle this operator co_await yet"); - Diags.Report(Loc, DiagID); - break; - } - case OO_None: case NUM_OVERLOADED_OPERATORS: llvm_unreachable("Not an overloaded operator"); diff --git a/test/CodeGenCoroutines/microsoft-abi-operator-coawait.cpp b/test/CodeGenCoroutines/microsoft-abi-operator-coawait.cpp new file mode 100644 index 0000000000..e87fed09f1 --- /dev/null +++ b/test/CodeGenCoroutines/microsoft-abi-operator-coawait.cpp @@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc18.0.0 -fcoroutines -emit-llvm %s -o - -std=c++14 -disable-llvm-passes | FileCheck %s +struct no_suspend { + bool await_ready() { return true; } + template void await_suspend(F) {} + void await_resume() {} +}; + +struct A { + no_suspend operator co_await() { return {}; } +}; + +struct B {}; + +no_suspend operator co_await(B const&) { return {}; } + +// CHECK-LABEL: f( +extern "C" void f() { + A a; + B b; + // CHECK: call void @"\01??__LA@@QEAA?AUno_suspend@@XZ"( + a.operator co_await(); + // CHECK-NEXT: call i8 @"\01??__L@YA?AUno_suspend@@AEBUB@@@Z"( + operator co_await(b); +} +