From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 5 Sep 2015 20:15:38 +0000 (-0400)
Subject: Fix CreateTableSpace() so it will compile without HAVE_SYMLINK.
X-Git-Tag: REL9_6_BETA1~1407
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9270d8db9a1cd6465e21215e6451b552995fcb08;p=postgresql

Fix CreateTableSpace() so it will compile without HAVE_SYMLINK.

This has been broken since 9.3 (commit 82b1b213cad3a69c to be exact),
which suggests that nobody is any longer using a Windows build system that
doesn't provide a symlink emulation.  Still, it's wrong on its own terms,
so repair.

YUriy Zhuravlev
---

diff --git a/src/backend/commands/tablespace.c b/src/backend/commands/tablespace.c
index ff0d904b7a..7588b7ae26 100644
--- a/src/backend/commands/tablespace.c
+++ b/src/backend/commands/tablespace.c
@@ -383,13 +383,14 @@ CreateTableSpace(CreateTableSpaceStmt *stmt)
 
 	/* We keep the lock on pg_tablespace until commit */
 	heap_close(rel, NoLock);
+
+	return tablespaceoid;
 #else							/* !HAVE_SYMLINK */
 	ereport(ERROR,
 			(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("tablespaces are not supported on this platform")));
+	return InvalidOid;			/* keep compiler quiet */
 #endif   /* HAVE_SYMLINK */
-
-	return tablespaceoid;
 }
 
 /*