From: Michael Foord <fuzzyman@voidspace.org.uk>
Date: Tue, 14 Jul 2009 17:58:12 +0000 (+0000)
Subject: Move TestRunner initialisation into unittest.TestProgram.runTests. Fixes issue 6418.
X-Git-Tag: v2.7a1~772
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=91dcd93bebcf974d12a300e6a8d0fc6eb9891884;p=python

Move TestRunner initialisation into unittest.TestProgram.runTests. Fixes issue 6418.
---

diff --git a/Lib/test/test_unittest.py b/Lib/test/test_unittest.py
index 92a5fad85f..29f897591a 100644
--- a/Lib/test/test_unittest.py
+++ b/Lib/test/test_unittest.py
@@ -3324,15 +3324,6 @@ class Test_TestProgram(TestCase):
         self.assertEqual(runner.test, test)
         self.assertEqual(program.verbosity, 2)
 
-
-    def testTestProgram_testRunnerArgument(self):
-        program = object.__new__(TestProgram)
-        program.parseArgs = lambda _: None
-        program.runTests = lambda: None
-        program.__init__(testRunner=None)
-        self.assertEqual(program.testRunner, unittest.TextTestRunner)
-
-
     class FooBar(unittest.TestCase):
         def testPass(self):
             assert True
diff --git a/Lib/unittest.py b/Lib/unittest.py
index bf7baa11c8..064429c447 100644
--- a/Lib/unittest.py
+++ b/Lib/unittest.py
@@ -1643,8 +1643,6 @@ class TestProgram(object):
                  argv=None, testRunner=None,
                  testLoader=defaultTestLoader, exit=True,
                  verbosity=1):
-        if testRunner is None:
-            testRunner = TextTestRunner
         if isinstance(module, basestring):
             self.module = __import__(module)
             for part in module.split('.')[1:]:
@@ -1734,6 +1732,8 @@ class TestProgram(object):
         self.test = loader.discover(start_dir, pattern, top_level_dir)
 
     def runTests(self):
+        if self.testRunner is None:
+            self.testRunner = TextTestRunner
         if isinstance(self.testRunner, (type, types.ClassType)):
             try:
                 testRunner = self.testRunner(verbosity=self.verbosity)