From: Wez Furlong <wez@php.net>
Date: Thu, 22 Apr 2004 14:27:11 +0000 (+0000)
Subject: A working fix for the safearray mapping bug.
X-Git-Tag: php-5.0.0RC2~24
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=91dc1a516a4609087975c45fa527145db79835ca;p=php

A working fix for the safearray mapping bug.
---

diff --git a/ext/com_dotnet/com_variant.c b/ext/com_dotnet/com_variant.c
index 4ea49bea57..48a0a66c20 100644
--- a/ext/com_dotnet/com_variant.c
+++ b/ext/com_dotnet/com_variant.c
@@ -37,18 +37,24 @@ static void safe_array_from_zval(VARIANT *v, zval *z, int codepage TSRMLS_DC)
 	SAFEARRAY *sa = NULL;
 	SAFEARRAYBOUND bound;
 	HashPosition pos;
+	int keytype;
 	char *strindex;
 	int strindexlen;
 	long intindex;
 	long max_index = 0;
 	VARIANT *va;
 	zval **item;
-
+		
 	/* find the largest array index, and assert that all keys are integers */
 	zend_hash_internal_pointer_reset_ex(HASH_OF(z), &pos);
 	for (;; zend_hash_move_forward_ex(HASH_OF(z), &pos)) {
-		if (HASH_KEY_IS_LONG != zend_hash_get_current_key_ex(HASH_OF(z), &strindex, &strindexlen, &intindex, 0, &pos)) {
+
+		keytype = zend_hash_get_current_key_ex(HASH_OF(z), &strindex, &strindexlen, &intindex, 0, &pos);
+
+		if (HASH_KEY_IS_STRING == keytype) {
 			goto bogus;
+		} else if (HASH_KEY_NON_EXISTANT == keytype) {
+			break;
 		}
 		if (intindex > max_index) {
 			max_index = intindex;
@@ -57,25 +63,25 @@ static void safe_array_from_zval(VARIANT *v, zval *z, int codepage TSRMLS_DC)
 
 	/* allocate the structure */	
 	bound.lLbound = 0;
-	bound.cElements = intindex;
+	bound.cElements = intindex + 1;
 	sa = SafeArrayCreate(VT_VARIANT, 1, &bound);
 
 	/* get a lock on the array itself */
-	SafeArrayLock(sa);
+	SafeArrayAccessData(sa, &va);
 	va = (VARIANT*)sa->pvData;
 	
 	/* now fill it in */
 	zend_hash_internal_pointer_reset_ex(HASH_OF(z), &pos);
 	for (;; zend_hash_move_forward_ex(HASH_OF(z), &pos)) {
 		if (FAILURE == zend_hash_get_current_data_ex(HASH_OF(z), (void**)&item, &pos)) {
-			goto bogus;
+			break;
 		}
 		zend_hash_get_current_key_ex(HASH_OF(z), &strindex, &strindexlen, &intindex, 0, &pos);
 		php_com_variant_from_zval(&va[intindex], *item, codepage TSRMLS_CC);		
 	}
 
 	/* Unlock it and stuff it into our variant */
-	SafeArrayUnlock(sa);
+	SafeArrayUnaccessData(sa);
 	V_VT(v) = VT_ARRAY|VT_VARIANT;
 	V_ARRAY(v) = sa;
 
@@ -278,7 +284,9 @@ PHP_FUNCTION(com_variant_create_instance)
 		obj->code_page = codepage;
 	}
 
-	php_com_variant_from_zval(&obj->v, zvalue, obj->code_page TSRMLS_CC);
+	if (zvalue) {
+		php_com_variant_from_zval(&obj->v, zvalue, obj->code_page TSRMLS_CC);
+	}
 
 	if (ZEND_NUM_ARGS() >= 2) {
 
@@ -818,7 +826,7 @@ PHP_FUNCTION(variant_get_type)
 		return;
 	}
 	obj = CDNO_FETCH(zobj);
-
+		
 	RETURN_LONG(V_VT(&obj->v));
 }
 /* }}} */