From: K.Kosako <kosako@sofnec.co.jp>
Date: Thu, 6 Jul 2017 07:59:09 +0000 (+0900)
Subject: define node_new_enclosure_if_else()
X-Git-Tag: v6.5.0^2~147
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=91c92baeb66959a9660b4cdea4ff2ccd2de9eab6;p=onig

define node_new_enclosure_if_else()
---

diff --git a/src/regparse.c b/src/regparse.c
index 6001146..55aa3aa 100644
--- a/src/regparse.c
+++ b/src/regparse.c
@@ -1404,6 +1404,19 @@ onig_node_new_enclosure(int type)
   return node_new_enclosure(type);
 }
 
+static Node*
+node_new_enclosure_if_else(Node* cond, Node* Then, Node* Else)
+{
+  Node* n;
+  n = node_new_enclosure(ENCLOSURE_IF_ELSE);
+  CHECK_NULL_RETURN(n);
+
+  NODE_BODY(n) = cond;
+  ENCLOSURE_(n)->te.Then = Then;
+  ENCLOSURE_(n)->te.Else = Else;
+  return n;
+}
+
 static Node*
 node_new_memory(int is_named)
 {
@@ -2303,13 +2316,9 @@ node_new_general_newline(Node** node, ScanEnv* env)
     if (r != 0) goto err1;
   }
 
-  x = node_new_enclosure(ENCLOSURE_IF_ELSE);
+  x = node_new_enclosure_if_else(crnl, 0, ncc);
   if (IS_NULL(x)) goto err1;
 
-  NODE_BODY(x) = crnl;
-  ENCLOSURE_(x)->te.Then = 0;
-  ENCLOSURE_(x)->te.Else = ncc;
-
   *node = x;
   return 0;
 }
@@ -5009,17 +5018,13 @@ parse_enclosure(Node** np, OnigToken* tok, int term, UChar** src, UChar* end,
             }
           }
 
-          *np = node_new_enclosure(ENCLOSURE_IF_ELSE);
+          *np = node_new_enclosure_if_else(condition, Then, Else);
           if (IS_NULL(*np)) {
             onig_node_free(condition);
             onig_node_free(Then);
             onig_node_free(Else);
             return ONIGERR_MEMORY;
           }
-
-          NODE_BODY(*np) = condition;
-          ENCLOSURE_(*np)->te.Then = Then;
-          ENCLOSURE_(*np)->te.Else = Else;
         }
         goto end;
       }