From: Adrian Prantl Date: Wed, 23 Aug 2017 22:02:36 +0000 (+0000) Subject: Retire the llvm.dbg.mir hack after r311594. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=91ad652cd88254e8ba58849d43548edffffe602b;p=llvm Retire the llvm.dbg.mir hack after r311594. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@311610 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/LiveDebugValues.cpp b/lib/CodeGen/LiveDebugValues.cpp index 89a66496ddd..12451174643 100644 --- a/lib/CodeGen/LiveDebugValues.cpp +++ b/lib/CodeGen/LiveDebugValues.cpp @@ -447,12 +447,9 @@ void LiveDebugValues::transferSpillInst(MachineInstr &MI, // iterator in our caller. unsigned SpillBase; int SpillOffset = extractSpillBaseRegAndOffset(MI, SpillBase); - const Module *M = MF->getMMI().getModule(); const MachineInstr *DMI = &VarLocIDs[ID].MI; auto *SpillExpr = DIExpression::prepend( DMI->getDebugExpression(), DIExpression::NoDeref, SpillOffset); - // Add the expression to the metadata graph so isn't lost in MIR dumps. - M->getNamedMetadata("llvm.dbg.mir")->addOperand(SpillExpr); MachineInstr *SpDMI = BuildMI(*MF, DMI->getDebugLoc(), DMI->getDesc(), true, SpillBase, DMI->getDebugVariable(), SpillExpr); diff --git a/lib/CodeGen/MachineModuleInfo.cpp b/lib/CodeGen/MachineModuleInfo.cpp index 3999cd5eb7e..f0dd77ef0da 100644 --- a/lib/CodeGen/MachineModuleInfo.cpp +++ b/lib/CodeGen/MachineModuleInfo.cpp @@ -210,8 +210,6 @@ bool MachineModuleInfo::doInitialization(Module &M) { DbgInfoAvailable = UsesVAFloatArgument = UsesMorestackAddr = false; AddrLabelSymbols = nullptr; TheModule = &M; - if (getDebugMetadataVersionFromModule(M)) - M.getOrInsertNamedMetadata("llvm.dbg.mir"); return false; } diff --git a/lib/CodeGen/PrologEpilogInserter.cpp b/lib/CodeGen/PrologEpilogInserter.cpp index 1b82cd2158a..6e442065ef7 100644 --- a/lib/CodeGen/PrologEpilogInserter.cpp +++ b/lib/CodeGen/PrologEpilogInserter.cpp @@ -1086,9 +1086,6 @@ void PEI::replaceFrameIndices(MachineBasicBlock *BB, MachineFunction &Fn, auto *DIExpr = DIExpression::prepend(MI.getDebugExpression(), DIExpression::NoDeref, Offset); MI.getOperand(3).setMetadata(DIExpr); - const Module *M = Fn.getMMI().getModule(); - // Add the expression to the metadata graph so isn't lost in MIR dumps. - M->getNamedMetadata("llvm.dbg.mir")->addOperand(DIExpr); continue; } diff --git a/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp b/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp index 9321a956fbd..4e6e90fc4bb 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp @@ -848,10 +848,6 @@ static void transferDbgValues(SelectionDAG &DAG, DIBuilder &DIB, SDValue From, Dbg->getDebugLoc(), Dbg->getOrder()); Dbg->setIsInvalidated(); ClonedDVs.push_back(Clone); - - // Add the expression to the metadata graph so isn't lost in MIR dumps. - const Module *M = DAG.getMachineFunction().getMMI().getModule(); - M->getNamedMetadata("llvm.dbg.mir")->addOperand(Fragment); } for (SDDbgValue *Dbg : ClonedDVs) diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp index 7697b3d59b5..c5cee49c0c2 100644 --- a/lib/IR/Verifier.cpp +++ b/lib/IR/Verifier.cpp @@ -736,7 +736,7 @@ void Verifier::visitNamedMDNode(const NamedMDNode &NMD) { // There used to be various other llvm.dbg.* nodes, but we don't support // upgrading them and we want to reserve the namespace for future uses. if (NMD.getName().startswith("llvm.dbg.")) - AssertDI(NMD.getName() == "llvm.dbg.cu" || NMD.getName() == "llvm.dbg.mir", + AssertDI(NMD.getName() == "llvm.dbg.cu", "unrecognized named metadata node in the llvm.dbg namespace", &NMD); for (const MDNode *MD : NMD.operands()) {