From: Neal Norwitz <nnorwitz@gmail.com>
Date: Sun, 12 Aug 2007 17:11:13 +0000 (+0000)
Subject: Fix memory leak in os.readlink
X-Git-Tag: v2.6a1~1514
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=91a57216c95b84aa883816fcfacfdd6b91827113;p=python

Fix memory leak in os.readlink
---

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 8a78d8c152..24c9e15537 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5783,7 +5783,10 @@ posix_readlink(PyObject *self, PyObject *args)
 		return NULL;
 #ifdef Py_USING_UNICODE
 	v = PySequence_GetItem(args, 0);
-	if (v == NULL) return NULL;
+	if (v == NULL) {
+		PyMem_Free(path);
+		return NULL;
+	}
 
 	if (PyUnicode_Check(v)) {
 		arg_is_unicode = 1;
@@ -5795,8 +5798,9 @@ posix_readlink(PyObject *self, PyObject *args)
 	n = readlink(path, buf, (int) sizeof buf);
 	Py_END_ALLOW_THREADS
 	if (n < 0)
-		return posix_error_with_filename(path);
+		return posix_error_with_allocated_filename(path);
 
+	PyMem_Free(path);
 	v = PyString_FromStringAndSize(buf, n);
 #ifdef Py_USING_UNICODE
 	if (arg_is_unicode) {