From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sat, 21 Jul 2018 07:24:41 +0000 (-0700)
Subject: bpo-34166: Fix warnings in Tools/msgfmt.py. (GH-8367)
X-Git-Tag: v3.6.7rc1~165
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=916bcc6fde2db95199454b22f608648467fbbc54;p=python

bpo-34166: Fix warnings in Tools/msgfmt.py. (GH-8367)

(cherry picked from commit a692efe4733f98831cb51a9683877b152f754d14)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
---

diff --git a/Tools/i18n/msgfmt.py b/Tools/i18n/msgfmt.py
index b0751a1ffc..63d52d1f46 100755
--- a/Tools/i18n/msgfmt.py
+++ b/Tools/i18n/msgfmt.py
@@ -89,7 +89,7 @@ def generate():
                          7*4,               # start of key index
                          7*4+len(keys)*8,   # start of value index
                          0, 0)              # size and offset of hash table
-    output += array.array("i", offsets).tostring()
+    output += array.array("i", offsets).tobytes()
     output += ids
     output += strs
     return output
@@ -109,7 +109,8 @@ def make(filename, outfile):
         outfile = os.path.splitext(infile)[0] + '.mo'
 
     try:
-        lines = open(infile, 'rb').readlines()
+        with open(infile, 'rb') as f:
+            lines = f.readlines()
     except IOError as msg:
         print(msg, file=sys.stderr)
         sys.exit(1)
@@ -199,7 +200,8 @@ def make(filename, outfile):
     output = generate()
 
     try:
-        open(outfile,"wb").write(output)
+        with open(outfile,"wb") as f:
+            f.write(output)
     except IOError as msg:
         print(msg, file=sys.stderr)