From: Georg Brandl <georg@python.org>
Date: Sat, 4 Jun 2005 09:20:03 +0000 (+0000)
Subject: Bug #1196315: fix weakref.WeakValueDictionary constructor.
X-Git-Tag: v2.5a0~1743
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9166e1a24ac7b15776ffd38e436fa51a9b002674;p=python

Bug #1196315: fix weakref.WeakValueDictionary constructor.
---

diff --git a/Lib/weakref.py b/Lib/weakref.py
index c0669b0317..09bd0bee24 100644
--- a/Lib/weakref.py
+++ b/Lib/weakref.py
@@ -43,12 +43,12 @@ class WeakValueDictionary(UserDict.UserDict):
     # way in).
 
     def __init__(self, *args, **kw):
-        UserDict.UserDict.__init__(self, *args, **kw)
         def remove(wr, selfref=ref(self)):
             self = selfref()
             if self is not None:
                 del self.data[wr.key]
         self._remove = remove
+        UserDict.UserDict.__init__(self, *args, **kw)
 
     def __getitem__(self, key):
         o = self.data[key]()
diff --git a/Misc/NEWS b/Misc/NEWS
index 637ca2eb13..f15e87390b 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -141,6 +141,8 @@ Extension Modules
 Library
 -------
 
+- Bug #1196315: fix weakref.WeakValueDictionary constructor.
+
 - Bug #1213894: os.path.realpath didn't resolve symlinks that were the first
   component of the path.