From: Stephen Frost <sfrost@snowman.net>
Date: Fri, 30 Jan 2015 02:59:57 +0000 (-0500)
Subject: Fix BuildIndexValueDescription for expressions
X-Git-Tag: REL9_2_10~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=915290ee9033849e4fe25a066a135891f3a0982a;p=postgresql

Fix BuildIndexValueDescription for expressions

In 804b6b6db4dcfc590a468e7be390738f9f7755fb we modified
BuildIndexValueDescription to pay attention to which columns are visible
to the user, but unfortunatley that commit neglected to consider indexes
which are built on expressions.

Handle error-reporting of violations of constraint indexes based on
expressions by not returning any detail when the user does not have
table-level SELECT rights.

Backpatch to 9.0, as the prior commit was.

Pointed out by Tom.
---

diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c
index 014823a3d7..87e6f17d44 100644
--- a/src/backend/access/index/genam.c
+++ b/src/backend/access/index/genam.c
@@ -208,10 +208,15 @@ BuildIndexValueDescription(Relation indexRelation,
 		{
 			AttrNumber	attnum = idxrec->indkey.values[keyno];
 
-			aclresult = pg_attribute_aclcheck(indrelid, attnum, GetUserId(),
-											  ACL_SELECT);
-
-			if (aclresult != ACLCHECK_OK)
+			/*
+			 * Note that if attnum == InvalidAttrNumber, then this is an
+			 * index based on an expression and we return no detail rather
+			 * than try to figure out what column(s) the expression includes
+			 * and if the user has SELECT rights on them.
+			 */
+			if (attnum == InvalidAttrNumber ||
+				pg_attribute_aclcheck(indrelid, attnum, GetUserId(),
+									  ACL_SELECT) != ACLCHECK_OK)
 			{
 				/* No access, so clean up and return */
 				ReleaseSysCache(ht_idx);