From: Mickael Remond <mremond@process-one.net>
Date: Mon, 1 Aug 2016 13:29:47 +0000 (+0200)
Subject: Improve error message when try to call api on api root
X-Git-Tag: 16.08~6^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=90ea3ca3613d7e342ba64e45cefcbe1227ee88c7;p=ejabberd

Improve error message when try to call api on api root
---

diff --git a/src/mod_http_api.erl b/src/mod_http_api.erl
index a91c3c1a7..73e6f7e4e 100644
--- a/src/mod_http_api.erl
+++ b/src/mod_http_api.erl
@@ -253,7 +253,7 @@ process([Call], #request{method = 'GET', q = Data, ip = IP} = Req) ->
     catch
         %% TODO We need to refactor to remove redundant error return formatting
         throw:{error, unknown_command} ->
-            json_format({404, 40, <<"Command not found.">>});
+            json_format({404, 44, <<"Command not found.">>});
         _:_Error ->
 
         ?DEBUG("Bad Request: ~p ~p", [_Error, erlang:get_stacktrace()]),
@@ -263,7 +263,7 @@ process([], #request{method = 'OPTIONS', data = <<>>}) ->
     {200, ?OPTIONS_HEADER, []};
 process(_Path, Request) ->
     ?DEBUG("Bad Request: no handler ~p", [Request]),
-    badrequest_response().
+    json_error(400, 40, <<"Missing command name.">>).
 
 %% Be tolerant to make API more easily usable from command-line pipe.
 extract_args(<<"\n">>) -> [];