From: Dmitry Stogov <dmitry@php.net>
Date: Fri, 14 Mar 2008 18:37:17 +0000 (+0000)
Subject: Improve GC to support garbage created in destructors during objects utilization
X-Git-Tag: RELEASE_2_0_0a1~134
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=90e570be3b6159018ee1e0051c5f6ff7ca7f886b;p=php

Improve GC to support garbage created in destructors during objects utilization
---

diff --git a/Zend/tests/gc_029.phpt b/Zend/tests/gc_029.phpt
new file mode 100644
index 0000000000..12f40c18c9
--- /dev/null
+++ b/Zend/tests/gc_029.phpt
@@ -0,0 +1,33 @@
+--TEST--
+GC 028: GC and destructors
+--FILE--
+<?php
+class Foo {
+	public $bar;
+	public $x = array(1,2,3);
+	function __destruct() {
+		if ($this->bar !== null) {
+			$this->x = null;
+			unset($this->bar);
+		}
+	}
+}
+class Bar {
+	public $foo;
+        function __destruct() {
+                if ($this->foo !== null) {
+                        unset($this->foo);
+                }
+        }
+
+}
+$foo = new Foo();
+$bar = new Bar();
+$foo->bar = $bar;
+$bar->foo = $foo;
+unset($foo);
+unset($bar);
+var_dump(gc_collect_cycles());
+?>
+--EXPECT--
+int(2)
diff --git a/Zend/zend_gc.c b/Zend/zend_gc.c
index 239b219431..659ec55ec6 100644
--- a/Zend/zend_gc.c
+++ b/Zend/zend_gc.c
@@ -56,6 +56,7 @@ static void gc_globals_ctor_ex(zend_gc_globals *gc_globals TSRMLS_DC)
 	gc_globals->unused = NULL;
 	gc_globals->zval_to_free = NULL;
 	gc_globals->free_list = NULL;
+	gc_globals->next_to_free = NULL;
 
 	gc_globals->gc_runs = 0;
 	gc_globals->collected = 0;
@@ -138,7 +139,7 @@ ZEND_API void gc_init(TSRMLS_D)
 ZEND_API void gc_zval_possible_root(zval *zv TSRMLS_DC)
 {
 	if (UNEXPECTED(GC_G(free_list) != NULL &&
-		           GC_ZVAL_ADDRESS(zv) != NULL &&
+	               GC_ZVAL_ADDRESS(zv) != NULL &&
 		           GC_ZVAL_GET_COLOR(zv) == GC_BLACK)) {
 		zval_gc_info **p = &GC_G(free_list);
 
@@ -260,6 +261,9 @@ ZEND_API void gc_remove_zval_from_buffer(zval *zv)
 
 		while (*p != NULL) {
 			if (*p == (zval_gc_info*)zv) {
+				if (GC_G(next_to_free) == (zval_gc_info*)zv) {
+					GC_G(next_to_free) = ((zval_gc_info*)zv)->u.next;
+				}
 				*p = (*p)->u.next;
 				return;
 			}
@@ -470,14 +474,9 @@ static void zval_collect_white(zval *pz TSRMLS_DC)
 
 		if (Z_TYPE_P(pz) == IS_OBJECT) {
 			zobj_collect_white(pz TSRMLS_CC);
-			if (EXPECTED(EG(objects_store).object_buckets[Z_OBJ_HANDLE_P(pz)].valid &&
-			             Z_OBJ_HANDLER_P(pz, get_properties) != NULL)) {
-				Z_OBJPROP_P(pz)->pDestructor = NULL;
-			}
 		} else {
 			if (Z_TYPE_P(pz) == IS_ARRAY) {
 				zend_hash_apply(Z_ARRVAL_P(pz), (apply_func_t) children_collect_white TSRMLS_CC);
-				Z_ARRVAL_P(pz)->pDestructor = NULL;
 			}
 		}
 
@@ -521,30 +520,33 @@ static void gc_collect_roots(TSRMLS_D)
 	}
 }
 
+#define FREE_LIST_END ((zval_gc_info*)((-1)|~GC_COLOR))
+
 ZEND_API int gc_collect_cycles(TSRMLS_D)
 {
 	int count = 0;
 
 	if (GC_G(roots).next != &GC_G(roots)) {
-		zval_gc_info *p, *q, *orig_free_list;
+		zval_gc_info *p, *q, *orig_free_list, *orig_next_to_free;
 
 		if (GC_G(gc_active)) {
 			return 0;
 		}
 		GC_G(gc_runs)++;
-		GC_G(zval_to_free) = NULL;
+		GC_G(zval_to_free) = FREE_LIST_END;
 		GC_G(gc_active) = 1;
 		gc_mark_roots(TSRMLS_C);
 		gc_scan_roots(TSRMLS_C);
 		gc_collect_roots(TSRMLS_C);
 
 		orig_free_list = GC_G(free_list);
+		orig_next_to_free = GC_G(next_to_free);
 		p = GC_G(free_list) = GC_G(zval_to_free);
 		GC_G(zval_to_free) = NULL;
 		GC_G(gc_active) = 0;
 
 		/* First call destructors */
-		while (p) {
+		while (p != FREE_LIST_END) {
 			if (Z_TYPE(p->z) == IS_OBJECT) {
 				if (EG(objects_store).object_buckets &&
 					EG(objects_store).object_buckets[Z_OBJ_HANDLE(p->z)].valid &&
@@ -558,32 +560,47 @@ ZEND_API int gc_collect_cycles(TSRMLS_D)
 					} zend_end_try();
 				}
 			}
+			count++;
 			p = p->u.next;
 		}
 
+		/* Destroy zvals */
 		p = GC_G(free_list);
-		while (p) {
-			q = p->u.next;
+		while (p != FREE_LIST_END) {
+			GC_G(next_to_free) = p->u.next;
 			if (Z_TYPE(p->z) == IS_OBJECT) {
 				if (EG(objects_store).object_buckets &&
 					EG(objects_store).object_buckets[Z_OBJ_HANDLE(p->z)].valid &&
 					EG(objects_store).object_buckets[Z_OBJ_HANDLE(p->z)].bucket.obj.refcount <= 0) {
 					EG(objects_store).object_buckets[Z_OBJ_HANDLE(p->z)].bucket.obj.refcount = 1;
 					zend_try {
+						Z_TYPE(p->z) = IS_NULL;
 						zend_objects_store_del_ref_by_handle(Z_OBJ_HANDLE(p->z) TSRMLS_CC);
 					} zend_end_try();
 				}
+			} else if (Z_TYPE(p->z) == IS_ARRAY) {
+				Z_TYPE(p->z) = IS_NULL;
+				zend_hash_destroy(Z_ARRVAL(p->z));
+				FREE_HASHTABLE(Z_ARRVAL(p->z));
 			} else {
 				zend_try {
 					zval_dtor(&p->z);
 				} zend_end_try();
+				Z_TYPE(p->z) = IS_NULL;
 			}
+			p = GC_G(next_to_free);
+		}
+
+		/* Free zvals */
+		p = GC_G(free_list);
+		while (p != FREE_LIST_END) {
+			q = p->u.next;
 			FREE_ZVAL_EX(&p->z);
 			p = q;
-			count++;
 		}
 		GC_G(collected) += count;
 		GC_G(free_list) = orig_free_list;
+		GC_G(next_to_free) = orig_next_to_free;
 	}
 
 	return count;
diff --git a/Zend/zend_gc.h b/Zend/zend_gc.h
index a1d6c352f1..45fb3a7d68 100644
--- a/Zend/zend_gc.h
+++ b/Zend/zend_gc.h
@@ -106,6 +106,7 @@ typedef struct _zend_gc_globals {
 
 	zval_gc_info     *zval_to_free;		/* temporaryt list of zvals to free */
 	zval_gc_info     *free_list;
+	zval_gc_info     *next_to_free;
 
 	zend_uint gc_runs;
 	zend_uint collected;