From: Ilia Alshanetsky Date: Fri, 19 Dec 2003 14:24:59 +0000 (+0000) Subject: Fixed memory leak in tidy_getopt() when fetching string values. X-Git-Tag: php-5.0.0b3RC2~18 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=90a5af75f6d7cc2268390650732a12762d32ca04;p=php Fixed memory leak in tidy_getopt() when fetching string values. Removed unnecessary check in tidy_diagnose(). --- diff --git a/ext/tidy/tidy.c b/ext/tidy/tidy.c index c02062910d..f0bc9113ef 100644 --- a/ext/tidy/tidy.c +++ b/ext/tidy/tidy.c @@ -912,8 +912,6 @@ PHP_FUNCTION(tidy_diagnose) { TIDY_FETCH_OBJECT; - TIDY_PARSED_REPAIR_CHECK(obj); - if (tidyRunDiagnostics(obj->ptdoc->doc) >= 0) { tidy_doc_update_properties(obj TSRMLS_CC); RETURN_TRUE; @@ -1329,7 +1327,7 @@ PHP_FUNCTION(tidy_getopt) optval = php_tidy_get_opt_val(obj->ptdoc, opt, &optt TSRMLS_CC); switch (optt) { case TidyString: - RETVAL_STRING((char *)optval, 0); + RETURN_STRING((char *)optval, 0); break; case TidyInteger: