From: Gregory P. Smith Date: Tue, 11 Dec 2012 01:44:44 +0000 (-0800) Subject: 1 << 31 is invalid for signed integers, fix it by making 1 unsigned. X-Git-Tag: v3.3.1rc1~540^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=90555d0f0d0b8e4ffbbb37ba12a8e43020ad1e98;p=python 1 << 31 is invalid for signed integers, fix it by making 1 unsigned. Found by Clang trunk's Undefined-Behavior Sanitizer. [more to come] --- diff --git a/Modules/_sre.c b/Modules/_sre.c index 38d0127c99..d74bf443a3 100644 --- a/Modules/_sre.c +++ b/Modules/_sre.c @@ -452,7 +452,7 @@ SRE_CHARSET(SRE_CODE* set, SRE_CODE ch) } else { /* (32 bits per code word) */ - if (ch < 256 && (set[ch >> 5] & (1 << (ch & 31)))) + if (ch < 256 && (set[ch >> 5] & (1u << (ch & 31)))) return ok; set += 8; } @@ -491,7 +491,7 @@ SRE_CHARSET(SRE_CODE* set, SRE_CODE ch) block = -1; set += 64; if (block >=0 && - (set[block*8 + ((ch & 255)>>5)] & (1 << (ch & 31)))) + (set[block*8 + ((ch & 255)>>5)] & (1u << (ch & 31)))) return ok; set += count*8; }